Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio compatible error output #355

Closed
gamli opened this issue Nov 3, 2016 · 3 comments
Closed

Visual Studio compatible error output #355

gamli opened this issue Nov 3, 2016 · 3 comments

Comments

@gamli
Copy link
Contributor

gamli commented Nov 3, 2016

The error format in the case of TypeScript compilation errors is not recognized by Visual Studio if Webpack with TS-Loader is used in a Build Event (i.e. errors are not shown with the correct file name in the Error List).

I implemented the feature for myself by replacing line 29 of utils.js

message: "" + '('.white + (lineChar.line + 1).toString().cyan + "," + (lineChar.character + 1).toString().cyan + "): " + messageText.red,

by

message: path.normalize(diagnostic.file.fileName).red + '('.white + (lineChar.line + 1).toString().cyan + "," + (lineChar.character + 1).toString().cyan + "): " + messageText.red,

So i wonder if this is something that could go into TS-Loader.

Kind Regards
Markus

@johnnyreilly
Copy link
Member

PRs are welcome!

@gamli
Copy link
Contributor Author

gamli commented Nov 3, 2016

Thx for the fast response :)
I created a PR (#356) for it.
The change itself is simple, but I had to change 63 files that contain the expected output of the tests.

@johnnyreilly
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants