Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buffer not string #36

Closed
basarat opened this issue Jan 29, 2015 · 7 comments
Closed

Use buffer not string #36

basarat opened this issue Jan 29, 2015 · 7 comments

Comments

@basarat
Copy link
Member

basarat commented Jan 29, 2015

Lots of calls to getText on atom editor. Also our languageServiceHost specifically ScriptSnapshot is working on string. Make it use nodejs Buffer. Also do this when reading files etc.

@basarat basarat added this to the SecondCut milestone Jan 29, 2015
@basarat
Copy link
Member Author

basarat commented Jan 30, 2015

@basarat
Copy link
Member Author

basarat commented Jan 30, 2015

Debounce linter further

Use on did change to just copy edit buffer.

And Debounce errors further

It is just might make autocomplete work as it is.

@basarat
Copy link
Member Author

basarat commented Jan 31, 2015

Debounce linter further
And Debounce errors further

Not needed.

Use on did change to just copy edit buffer.

Investigating.

@basarat
Copy link
Member Author

basarat commented Feb 1, 2015

It seems like this is not the issue. The program.languageServiceHost.updateScript(filePath, options.editor.getText()); call only takes under 1ms on a 1000 line file (considered a largish file for most purposes).

However the complete call to requestHandler in autocomplete plus is around 100ms
image

With getCompletion taking the majority of time.

image

So moving this to the wishlist category.

@basarat
Copy link
Member Author

basarat commented Feb 1, 2015

TODO: investigate if getCompletions makes calls to the language service host and consider optimizations if that is what is taking too long.

@basarat
Copy link
Member Author

basarat commented Feb 26, 2015

Probably a good thing to do after #130

@basarat basarat removed this from the 2 Second Cut milestone Mar 2, 2015
@basarat
Copy link
Member Author

basarat commented Mar 10, 2015

We are not going to use a buffer. Instead we will bring in the changes from TSServer

@basarat basarat closed this as completed Mar 10, 2015
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant