fix: Constructors were a bit broken

TypeStrong · Jan 17, 2021 · d746d85 · d746d85
1 parent 213760b
commit d746d85
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 58 deletions.
diff --git a/src/lib/converter/plugins/CommentPlugin.ts b/src/lib/converter/plugins/CommentPlugin.ts
@@ -288,7 +288,10 @@ export class CommentPlugin extends ConverterComponent {
             hidden
                 .map((reflection) => reflection.parent!)
                 .filter((method) =>
-                    method.kindOf(ReflectionKind.FunctionOrMethod)
+                    method.kindOf(
+                        ReflectionKind.FunctionOrMethod |
+                            ReflectionKind.Constructor
+                    )
                 ) as DeclarationReflection[],
             (method) => method.signatures?.length === 0
         );

diff --git a/src/lib/converter/symbols.ts b/src/lib/converter/symbols.ts
@@ -385,7 +385,11 @@ function convertClassOrInterface(
 
         constructMember.signatures = staticType
             .getConstructSignatures()
-            .map((sig) => {
+            .map((sig, i) => {
+                // Modifiers are the same for all constructors
+                if (sig.declaration && i === 0) {
+                    setModifiers(sig.declaration, constructMember);
+                }
                 const sigRef = createSignature(
                     constructContext,
                     ReflectionKind.ConstructorSignature,

diff --git a/src/test/converter/class/access.ts b/src/test/converter/class/access.ts
@@ -52,4 +52,7 @@ export class PrivateClass {
     fakeProtectedMethod() {}
 
     private privateArrow = () => {};
+
+    /** @hidden - should not show up */
+    constructor() {}
 }
diff --git a/src/test/converter/class/specs-with-lump-categories.json b/src/test/converter/class/specs-with-lump-categories.json
@@ -23,27 +23,6 @@
             "shortText": "A class that is documented as being private."
           },
           "children": [
-            {
-              "id": 9,
-              "name": "constructor",
-              "kind": 512,
-              "kindString": "Constructor",
-              "flags": {},
-              "signatures": [
-                {
-                  "id": 10,
-                  "name": "new PrivateClass",
-                  "kind": 16384,
-                  "kindString": "Constructor signature",
-                  "flags": {},
-                  "type": {
-                    "type": "reference",
-                    "id": 8,
-                    "name": "PrivateClass"
-                  }
-                }
-              ]
-            },
             {
               "id": 11,
               "name": "fakePrivateProperty",
@@ -154,13 +133,6 @@
             }
           ],
           "groups": [
-            {
-              "title": "Constructors",
-              "kind": 512,
-              "children": [
-                9
-              ]
-            },
             {
               "title": "Properties",
               "kind": 1024,

diff --git a/src/test/converter/class/specs.json b/src/test/converter/class/specs.json
@@ -23,27 +23,6 @@
             "shortText": "A class that is documented as being private."
           },
           "children": [
-            {
-              "id": 9,
-              "name": "constructor",
-              "kind": 512,
-              "kindString": "Constructor",
-              "flags": {},
-              "signatures": [
-                {
-                  "id": 10,
-                  "name": "new PrivateClass",
-                  "kind": 16384,
-                  "kindString": "Constructor signature",
-                  "flags": {},
-                  "type": {
-                    "type": "reference",
-                    "id": 8,
-                    "name": "PrivateClass"
-                  }
-                }
-              ]
-            },
             {
               "id": 11,
               "name": "fakePrivateProperty",
@@ -154,13 +133,6 @@
             }
           ],
           "groups": [
-            {
-              "title": "Constructors",
-              "kind": 512,
-              "children": [
-                9
-              ]
-            },
             {
               "title": "Properties",
               "kind": 1024,