Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable to search "+1" for "thumbsup" #207

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

soundlake
Copy link
Contributor

It is a nitpick. If "-1" is searchable, why not for "+1"?

It is a nitpick. If "-1" is searchable, why not for "+1"?
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #207 into master will decrease coverage by 0.2%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   69.21%   69.01%   -0.21%     
==========================================
  Files          16       16              
  Lines         666      668       +2     
  Branches       63       64       +1     
==========================================
  Hits          461      461              
- Misses        180      182       +2     
  Partials       25       25
Impacted Files Coverage Δ
src/lib/picker/emoji-search.service.ts 81.18% <50%> (-0.64%) ⬇️
src/lib/picker/category.component.ts 80.76% <0%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8244a4...c08b902. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #207 into master will decrease coverage by 0.2%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   69.21%   69.01%   -0.21%     
==========================================
  Files          16       16              
  Lines         666      668       +2     
  Branches       63       64       +1     
==========================================
  Hits          461      461              
- Misses        180      182       +2     
  Partials       25       25
Impacted Files Coverage Δ
src/lib/picker/emoji-search.service.ts 81.18% <50%> (-0.64%) ⬇️
src/lib/picker/category.component.ts 80.76% <0%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8244a4...c08b902. Read the comment docs.

@scttcper scttcper changed the title Enable to search "+1" for "thumbsup" fix: Enable to search "+1" for "thumbsup" Apr 29, 2019
@scttcper scttcper merged commit 87f4ac6 into scttcper:master Apr 29, 2019
@scttcper
Copy link
Owner

🎉 This PR is included in version 0.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants