Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize all strings #218

Closed
YousefED opened this issue May 30, 2023 · 5 comments · Fixed by #652
Closed

Externalize all strings #218

YousefED opened this issue May 30, 2023 · 5 comments · Fixed by #652
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers prio:low Low priority

Comments

@YousefED
Copy link
Collaborator

YousefED commented May 30, 2023

Make sure all strings used in BlockNote are configurable, so that it can also be used in different languages.

The initial approach should just be that strings can be passed to options - which should be enough for other applications to customize / localize. Later, we can see if we want to build in support for different languages or i18n.

@YousefED YousefED added good first issue Good for newcomers enhancement New feature or request labels May 30, 2023
@sudarshanshenoy
Copy link
Contributor

Can I pick this?

@YousefED
Copy link
Collaborator Author

YousefED commented Jun 5, 2023

Can I pick this?

Would be great!

@simonfan
Copy link

Hey there! Great work on the project, thanks! How is this specific issue going? I would be very willing to collaborate :)

@YousefED
Copy link
Collaborator Author

@simonfan for sure! I think a good first step would be to create a DictionaryContext and put all strings on there - and make sure components retrieve them from this context. Then after that, we can figure out a good API to provide a dictionary for different languages

@simonfan
Copy link

Great! As a first step, I'll just locate all text strings and think of a suggestion on how to proceed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers prio:low Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants