Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Proxy Support #139

Open
JonatanSalas opened this issue May 24, 2018 · 0 comments · May be fixed by #140
Open

[Feature Request] - Proxy Support #139

JonatanSalas opened this issue May 24, 2018 · 0 comments · May be fixed by #140

Comments

@JonatanSalas
Copy link

Our apps, are behind a proxy network, we're using this library for one of our projects. It would be really nice, if you add support for proxy.

https://aws.amazon.com/es/blogs/developer/using-the-aws-sdk-for-javascript-from-behind-a-proxy/

var AWS = require('aws-sdk');
var proxy = require('proxy-agent');

AWS.config.update({
  httpOptions: { 
    agent: proxy('http://user:[email protected]') 
  }
});

var s3 = new AWS.S3({region: 'us-west-2'});
s3.getObject({Bucket: 'bucket', Key: 'key'}, function (err, data) {
  console.log(err, data);
});

Would you mind if I make you a PR?

@JonatanSalas JonatanSalas linked a pull request May 24, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant