Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Libtask 0.7 #1779

Closed
wants to merge 1 commit into from
Closed

Switch to Libtask 0.7 #1779

wants to merge 1 commit into from

Conversation

rikhuijzer
Copy link
Contributor

Pinning explicitly to Libtask 0.7 to avoid the an abstract field in TapedTask. See TuringLang/Libtask.jl#123 for details.

@rikhuijzer rikhuijzer requested a review from devmotion February 21, 2022 09:33
@rikhuijzer rikhuijzer mentioned this pull request Feb 21, 2022
Merged
@devmotion
Copy link
Member

IMO this should not be merged and we should wait until AdvancedPS is updated (Trace struct etc.). I think it's a mistake that AdvancedPS is declared to be compatible with Libtask 0.7.

@rikhuijzer rikhuijzer marked this pull request as draft February 21, 2022 09:49
@yebai
Copy link
Member

yebai commented Feb 24, 2022

Closed in favour of #1783

@yebai yebai closed this Feb 24, 2022
@yebai yebai deleted the rh/libtask-0.7 branch February 24, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion Awaiting requested review from devmotion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikhuijzer @devmotion @yebai