Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CollectVariables #151

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Refactor CollectVariables #151

merged 9 commits into from
Mar 7, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Mar 7, 2024

  • Refactor the analyze_assignment function of CollectVariables
  • Added some tests for the functions
  • Speed is improved a little bit on some examples

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 8191161964

Details

  • 23 of 24 (95.83%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 81.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/compiler_pass.jl 23 24 95.83%
Totals Coverage Status
Change from base Build 8189132467: 0.9%
Covered Lines: 1585
Relevant Lines: 1938

💛 - Coveralls

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.78%. Comparing base (4b05532) to head (f632f2a).

Files Patch % Lines
src/compiler_pass.jl 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   80.90%   81.78%   +0.87%     
==========================================
  Files          21       21              
  Lines        1943     1938       -5     
==========================================
+ Hits         1572     1585      +13     
+ Misses        371      353      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/passes.jl Outdated Show resolved Hide resolved
test/passes.jl Outdated Show resolved Hide resolved
test/passes.jl Outdated Show resolved Hide resolved
test/passes.jl Outdated Show resolved Hide resolved
test/passes.jl Outdated Show resolved Hide resolved
test/passes.jl Outdated Show resolved Hide resolved
@sunxd3 sunxd3 merged commit 43daf28 into master Mar 7, 2024
13 of 15 checks passed
@sunxd3 sunxd3 deleted the sunxd/patch-1 branch March 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants