Fix serialization bug

[miguelbiron]

Closes #261

[miguelbiron]

Confirmed locally that it fixes the reproducible example in #261

[miguelbiron]

Lol I guess the way I wrote it is not standard. Gonna change that.

[coveralls]

Pull Request Test Coverage Report for Build 12325792494

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.8%) to 73.269%

---

Totals
Change from base Build 12325790987:	0.8%
Covered Lines:	1439
Relevant Lines:	1964

---

💛 - Coveralls

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (4f4772a) to head (355720f).
Report is 63 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   82.09%   73.26%   -8.83%     
==========================================
  Files          20       20              
  Lines        1748     1964     +216     
==========================================
+ Hits         1435     1439       +4     
- Misses        313      525     +212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miguelbiron]

I don't understand why the serialization test you wrote didn't pick up this bug though. Maybe if you are in the same session the serializer just gets the current object? would be weird.

[sunxd3]

No I think the test wasn't actually run, fixing at #263

thanks for suggesting looking into it

[sunxd3]

Sorry for before @miguelbiron the CI should be fixed now, could you uncomment the tests for serialization and see if they run?

[miguelbiron]

Will do

[miguelbiron]

Seems like activating the tests reduced coverage? Not sure how that could happen. And the benchmark issue seems related to permissions.

[sunxd3]

benchmark might error because BridgeStan is segfaulting on macOS, so as long as it runs, it's okay

[sunxd3]

thanks!