You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm mainly concerned about the, in most cases, incorrect results of logprior currently - which is the main reason for this annoying leafcontext approach. I think this could be fixed by identifying it with a custom observe statement instead of an arbitrary modification of the log probability. One could eg. change the macro syntax to
@addlogprob! val [assume=false] [observe=true]
Then it would still be possible to unconditionally modify the log probability but one could also limit it easily to evaluations that include the likelihood or the prior.
The text was updated successfully, but these errors were encountered:
devmotion
changed the title
I'm mainly concerned about the, in most cases, incorrect results of logprior currently - which is the main reason for this annoying leafcontext approach. I think this could be fixed by identifying it with a custom observe statement instead of an arbitrary modification of the log probability. One could eg. change the macro syntax to
Improve @addlogprob!Mar 7, 2022
I'm mainly concerned about the, in most cases, incorrect results of
logprior
currently - which is the main reason for this annoyingleafcontext
approach. I think this could be fixed by identifying it with a custom observe statement instead of an arbitrary modification of the log probability. One could eg. change the macro syntax toThen it would still be possible to unconditionally modify the log probability but one could also limit it easily to evaluations that include the likelihood or the prior.
Originally posted by @devmotion in #389 (comment)
The text was updated successfully, but these errors were encountered: