Default bijector implementation for TransformedDistribution
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
approved these changes
Jun 13, 2021
|
Maybe add a test? |
|
Yeaaah I was thinking about it, but then when I was about too I went "wait, but I want the test to the implementation..." 😅 So I don't think there's much point tbh. |
|
Yeah, I guess the main point would be to ensure that it exists and it returns correct values for a random input for transformed distributions with specific transforms (e.g. identity and exponentiation). |
|
Added a couple 👍 |
devmotion
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're missing an implementation for
bijector(td::TransformedDistribution)which in turn means that you can't, without a bit of work, use transformed distributions in, say, a DPPL-model.This is stupid because it's trivial to construct this bijector: just invert
td.transform, bringing us back the original domain oftd.dist, and then compose this with the bijector fortd.dist, which then takes us to real space.EDIT: Btw, I have the right to call it stupid because I'm the one who didn't do it.