Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster modules - New modules/features #845

Closed
9 of 10 tasks
DenisCarriere opened this issue Jul 16, 2017 · 3 comments
Closed
9 of 10 tasks

Cluster modules - New modules/features #845

DenisCarriere opened this issue Jul 16, 2017 · 3 comments

Comments

@DenisCarriere
Copy link
Member

DenisCarriere commented Jul 16, 2017

Cluster Modules/Features

The past few cluster related modules have helped us define some of the "nice to have" features related to GeoJSON clustering. I propose we start a collection of clusters-<name> modules for specific clustering algorithms (mainly focusing on the GeoJSON implementation & leveraging an external dependency for the algorithm) and use @turf/clusters as a utility module for common clustering methods & operations:

To-Do

  • Rename @turf/clusters => @turf/clusters-kmeans
  • Add deprecated warning message to @turf/clusters in favor of using @turf/clusters-kmeans (major release v5.0 calling it the Cluster Release @turf/clusters was never actually published to v4.5.0, going to bump this change to v4.6.0)
  • Rename @turf/clusters-dbscan => @turf/cluster-dbscan
  • (Optional) Change output of @turf/clusters-kmeans to pure GeoJSON output FeatureCollection<Point> (each feature will still include cluster property) in favor of leveraging the @turf/clusters utility tools to generate derived centroids and/or concave polygons.

So far it's been @stebogit & @DenisCarriere driving the direction of these clusters modules, however I would love to hear some feedback from @Turfjs/ownership before we publish the next release of these cluster modules.

EDIT: Changed cluster => clusters (plural module name to prevent any accidental conflicts with cluster property).

@DenisCarriere
Copy link
Member Author

@stebogit Ok finished adding all @turf/clusters methods (getCluster, clusterEach, clusterReduce). Looking forward to your feedback (no rush)

@stebogit
Copy link
Collaborator

Implemented with PR #847

@DenisCarriere
Copy link
Member Author

Woot! All done! Definitely open to suggestions for new features in @turf/clusters, those 3 methods was just to get something started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants