-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Supporting "meters" unit #1298
Comments
Thanks for the report @ozomer , good pickup! |
Meters is included in the source code: https://github.com/Turfjs/turf/blob/master/packages/turf-helpers/index.mjs#L10-L11 I agreed that we could add "meters" in the docs, however we shouldn't include every single unit of measurement in the docs (keep it short & simple). |
I've always been converting meters to kilometers since I didn't know meters is supported too.
I disagree, the documentation should document all supported options. |
I'd love to have the documentation be accurate everywhere but that involves a bunch of duplication that our docs aren't setup for right now. As a half measure, the typescript types reference the canonical list, so any typescript consumers will now get the full list. |
@smallsaucepan I'm open to this approach if you want to give it a try. Holler if you have questions |
The Units typedef now has it's own page on the website: https://turfjs.org/docs/next/api/types/Units As we update documentation for each method they'll begin to link to the full list of options automatically. |
Hi,
All operations that accepts units of "degrees, radians, miles, or kilometers" can also accept "meters".
One of our developers called
distance
with unit "kilometers" and divided the result by 1000, because the documentation did not specify that it supports meters too.Minor issue, not critical...
The text was updated successfully, but these errors were encountered: