Prefix error + warning messages #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you add a quick screenshot of how the notification changes due to this? |
|
This is an example of an error: |
|
ah cool, thanks! |
Turbo87
added a commit
that referenced
this pull request
Feb 22, 2016
Prefix error + warning messages
|
Cool, are you planning a new release soon? |
|
@martijnrusschen just published v1.3.0. should be available on NPM in a few minutes. |
|
Awesome! |
|
might be a few more minutes. looks like the TravisCI deploy thing didn't work as it should (https://travis-ci.org/Turbo87/webpack-notifier/builds/110943200) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since your file names are pretty long normally, the only thing I can see in the notifications are the filenames. I'd prefer to have the notification start with
Error:orWarning:instead.