Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format to use implicit keyword argument #71

Open
abelsiqueira opened this issue Aug 9, 2024 · 3 comments
Open

Change format to use implicit keyword argument #71

abelsiqueira opened this issue Aug 9, 2024 · 3 comments

Comments

@abelsiqueira
Copy link
Member

In various places in the code we use foo(x; y=y) and this can be changed to foo(x; y). We can update that.

@clizbe, do you think we should start documenting these code formatting options that JuliaFormatter does not pick up? Or do we just leave it more loosely defined?

@clizbe
Copy link
Member

clizbe commented Aug 12, 2024

Hmm good question. How many of these things are we doing that aren't documented?

Also, it's an open issue for JuliaFormatter:

@abelsiqueira
Copy link
Member Author

Probably not many. One that we use in TEM but not in TIO yet is something like "use long descriptive names for functions, preferably don't abbreviate". There is also the naming convention of "StructName", "function_name", "variable_name", etc., but those are pretty standard in Julia.

@clizbe
Copy link
Member

clizbe commented Aug 19, 2024

I think for now we don't need to document. We can maybe keep an eye out when reviewing PRs and train new people to make their code coherent with ours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants