Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should gutters be applied when columns are stacked? #3

Open
mrmartineau opened this issue Nov 1, 2016 · 1 comment
Open

Should gutters be applied when columns are stacked? #3

mrmartineau opened this issue Nov 1, 2016 · 1 comment

Comments

@mrmartineau
Copy link
Member

See the gutter code here: https://github.com/TryKickoff/kickoff-grid.css/blob/master/scss/index.scss#L62-L70

Should this not be removed when the columns are stacked? Like only above a specific breakpoint.

Could something like this be used so that gutters are applied only above a certain breakpoint?

.g--gutter--mid {}
@ashleynolan
Copy link
Contributor

So the main gutter does get removed, it’s only the outer gutter that stays and that is counteracted by the negative margins on the outside of the grid.

I’ve got a test case on the JE site that looks like it works ok, but I’ll try setting up some generic ones in the docs as well just to make sure this works as planned (unless you have an example of it not working as expected?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants