Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to windows-latest once node-gyp is bumped #1565

Closed
daniellockyer opened this issue Apr 12, 2022 · 0 comments
Closed

Update CI to windows-latest once node-gyp is bumped #1565

daniellockyer opened this issue Apr 12, 2022 · 0 comments
Assignees
@daniellockyer
Labels
ci

Comments

@daniellockyer
Copy link
Member

I had to use windows-2019 for CI because the version of node-gyp we use doesn't support VS 2022.

node-gyp 8.4.0 does support it: nodejs/node-gyp@5a00387

Once we've bumped the node-gyp version, we should be good to switch to windows-latest
@daniellockyer daniellockyer self-assigned this Apr 12, 2022
daniellockyer added a commit that referenced this issue Apr 12, 2022
@daniellockyer
Updated Windows CI runner to windows-latest
9acd85d 
#1565

- now `node-gyp` has been updated to 8.x, we should now support building
  on Visual Studio 22
- this was the blocker from using `windows-latest`, so we can now update
  to that
@daniellockyer daniellockyer mentioned this issue Apr 12, 2022
Merged
daniellockyer added a commit that referenced this issue Apr 12, 2022
@daniellockyer
Updated Windows CI runner to windows-latest
d87e66e 
closes #1565

- now `node-gyp` has been updated to 8.x, we should now support building
  on Visual Studio 22
- this was the blocker from using `windows-latest`, so we can now update
  to that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniellockyer daniellockyer

Labels
ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniellockyer