-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sqlite3 context aware for Electron 7+ compatibility #1274
Comments
We need to investigate #1007 again to make node-sqlite3 compatible with worker threads. |
There is also an open issue to add: N-API Support #830 which I guess would also solve this too - however that has been worked on for over 2 years now. If Electron maintains their 12 week release schedule, version 11 (which will drop support for non converted modules) could be released around November 2020. |
With the shortage of contributors here, can I safely assume that Electron 8 will not be fully supported for a good while still? Or if there's a pretty good chance it will be coming pretty soon, could I get a rough time frame for that? Speak of the holy devil. That timing couldn't have been crazier: #1294 I'm super excited for this |
#1304 |
@kewde thank you very much for your follow-up, much appreciated ! |
Glad this change is made @kewde, when do you think 5.0.0 will be published to npm? |
@aabuhijleh v5 has been released (https://github.com/mapbox/node-sqlite3/releases/tag/v5.0.0) and is available on npm (https://www.npmjs.com/package/sqlite3) |
thank you @kewde ! 🎉 |
We use sqlite3 in an Electron application and Electron is soon requiring Native Modules in the Renderer Process to be NAPI or Context Aware.
Is it possible to make sqlite3 Context Aware?
See electron/electron#18397 and an example https://github.com/atom/node-keytar/pull/182/files
Thanks
The text was updated successfully, but these errors were encountered: