Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GScan should be able to remove checks from previous major versions #135

Closed
aileen opened this issue Aug 12, 2018 · 3 comments
Closed

GScan should be able to remove checks from previous major versions #135

aileen opened this issue Aug 12, 2018 · 3 comments
Assignees
@naz
Labels
enhancement

Comments

@aileen
Copy link
Member

aileen commented Aug 12, 2018

The current logic in GScan 2.0 adds new rulesets on top of the old rulesets. There is currently no way to remove a rule, template, or known helper, that we don't want to check for anymore in the latest version.
@aileen aileen self-assigned this Aug 12, 2018
@aileen aileen mentioned this issue Aug 12, 2018
Closed
7 tasks
aileen added a commit to aileen/gscan that referenced this issue Aug 12, 2018
@aileen
Added ability to remove rules from checks
ec2c867 
refs TryGhost#135

- added functionality in the latest spec to exlude helpers, templates, or rules from further checks
@aileen aileen mentioned this issue Aug 12, 2018
Closed
aileen added a commit to aileen/gscan that referenced this issue Aug 13, 2018
@aileen
Added ability to remove rules from checks
2aa7644 
refs TryGhost#135

- added functionality in the latest spec to exlude helpers, templates, or rules from further checks
aileen added a commit to aileen/gscan that referenced this issue Aug 13, 2018
@aileen
Added ability to remove rules from checks
bf850aa 
closes TryGhost#135

- added functionality in the latest spec to exlude helpers, templates, or rules from further checks
aileen added a commit to aileen/gscan that referenced this issue Aug 13, 2018
@aileen
Added ability to remove rules from checks
df48915 
closes TryGhost#135

- added functionality in the latest spec to exlude helpers, templates, or rules from further checks
@aileen aileen changed the title GScan 2.0 should be able to remove older checks GScan should be able to remove checks from previous major versions Aug 20, 2018
@aileen
Copy link
Member Author

aileen commented May 8, 2019

@gargol assigned you to this now, as I assume you're going through the GScan issues now?

@aileen aileen assigned naz and unassigned aileen May 8, 2019
@naz
Copy link
Contributor

naz commented May 8, 2019

yup! thanks @AileenCGN 👍

@naz
Copy link
Contributor

naz commented Mar 29, 2022

It is possible to remove the rules by "removing" them from the "previousRules" set. An example of such removal is here.

@naz naz closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naz naz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErisDS @naz @aileen