Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated errors package to use TypeScript #122

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Conversation

binary-koan
Copy link
Contributor

@binary-koan binary-koan commented Nov 1, 2023

refs https://github.com/TryGhost/Product/issues/4078 (dependency of limit-service)

  • Migrated the package to TypeScript
  • Removed lodash as a dependency
  • Simplified how utils work to just import other files instead of having setup functions and this everywhere
  • Isolated utils functions more and marked package as "sideEffects": false so that stdlib doesn't need to be included in frontend bundles

@binary-koan binary-koan self-assigned this Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e9ffcc6) 87.03% compared to head (ee2a068) 87.66%.

Files Patch % Lines
packages/errors/src/utils.ts 98.73% 2 Missing and 1 partial ⚠️
packages/errors/src/GhostError.ts 97.91% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   87.03%   87.66%   +0.63%     
==========================================
  Files          72       74       +2     
  Lines        4204     4281      +77     
  Branches      590      595       +5     
==========================================
+ Hits         3659     3753      +94     
+ Misses        541      524      -17     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binary-koan binary-koan merged commit 98e9cca into main Dec 11, 2023
1 check passed
@binary-koan binary-koan deleted the errors-typescript branch December 11, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants