Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alto & Dawn need additional logic for white_logo_for_dark_mode to render correctly #371

Open
alexgmathews opened this issue Nov 21, 2024 · 0 comments

Comments

@alexgmathews
Copy link

alexgmathews commented Nov 21, 2024

Alto and Dawn double-print @site.logo <img> when @custom.white_logo_for_dark_mode exists:

<img src="{{@site.logo}}" alt="{{@site.title}}">
{{#if @custom.white_logo_for_dark_mode}}
    <img src="{{img_url @custom.white_logo_for_dark_mode}}" alt="{{@site.title}}">
{{/if}}

At first, I thought of creating an if/else switch to control which <img> tag to print (see PR 373).

However, that still wouldn't handle cases such as...

  • the user uploads @custom.white_logo_for_dark_mode but then switches the color scheme to light. Under current logic/PR 373, the dark logo would still show.
  • the user uploads @custom.white_logo_for_dark_mode and sets the color scheme to auto. Under current logic/PR 373, the dark logo would always show.

I think the logic needs to be more complex to handle the theme's automatic light/dark theming. Something like...

  1. if {{#match @custom.color_scheme "Dark"}} and @custom.white_logo_for_dark_mode, print <img> for @custom.white_logo_for_dark_mode
  2. if {{#match @custom.color_scheme "Auto"}} and @custom.white_logo_for_dark_mode, print <img> for @site.logo and @custom.white_logo_for_dark_mode and add IDs/classes and display: none CSS to control which <img> renders
  3. else print <img> for @site.logo
@alexgmathews alexgmathews changed the title Alto & Dawn need if/else construct for @custom.white_logo_for_dark_mode Alto & Dawn need additional logic for @custom.white_logo_for_dark_mode to render correctly Nov 22, 2024
@alexgmathews alexgmathews changed the title Alto & Dawn need additional logic for @custom.white_logo_for_dark_mode to render correctly Alto & Dawn need additional logic for white_logo_for_dark_mode to render correctly Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant