Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 German translations (thanks to thewolfofallstreetz on the Ghost forum) #21050

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

cathysarisky
Copy link
Contributor

@cathysarisky cathysarisky commented Sep 19, 2024

ref: https://forum.ghost.org/t/help-translate-ghost-beta/37461/113

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

@ronaldlangeveld ronaldlangeveld merged commit c23dc8a into TryGhost:main Sep 26, 2024
21 checks passed
@@ -25,12 +25,12 @@
"Cancel subscription": "Abonnement kündigen",
"Cancellation reason": "Kündigungsgrund",
"Change": "Ändern",
"Change plan": "",
"Change plan": "Tarif änder",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldlangeveld this looks like a typo — should be Tarif ändern I'd say (except there's some context that I don't have that adds an n).

@@ -1,5 +1,5 @@
{
"(save {{highestYearlyDiscount}}%)": "",
"(save {{highestYearlyDiscount}}%)": "(jetzt sparen {{highestYearlyDiscount}}%)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronaldlangeveld should be (jetzt {{highestYearlyDiscount}}% sparen)

("save now 20%" vs. "save 20% now")

(Sorry for jumping into this merged PR, just found it in an open tab and thought I'd share my two native speaker cents.)

@@ -85,7 +85,7 @@
"Manage": "Verwalten",
"Maybe later": "Vielleicht später",
"Memberships unavailable, contact the owner for access.": "",
"month": "",
"month": "monat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be capitalized as it's a noun: Monat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants