From dda1d7cf26e8cab8db54932363ee3b4eaf8af483 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Thu, 16 Mar 2023 20:40:58 +0100 Subject: [PATCH] Removed emojis from i18n strings refs https://github.com/TryGhost/Ghost/issues/15502 - these aren't going to change across languages so we can exclude them from the strings to simplify things --- ghost/core/core/server/services/members/api.js | 10 +++++----- .../core/core/server/services/members/emails/signin.js | 2 +- ghost/i18n/locales/en/ghost.json | 10 +++++----- ghost/i18n/locales/nl/ghost.json | 10 +++++----- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/ghost/core/core/server/services/members/api.js b/ghost/core/core/server/services/members/api.js index 4219d8cfb17..a408b8197b9 100644 --- a/ghost/core/core/server/services/members/api.js +++ b/ghost/core/core/server/services/members/api.js @@ -59,16 +59,16 @@ function createApiInstance(config) { const siteTitle = settingsCache.get('title'); switch (type) { case 'subscribe': - return t(`📫 Confirm your subscription to {{siteTitle}}`, {siteTitle}); + return `📫 ${t(`Confirm your subscription to {{siteTitle}}`, {siteTitle})}`; case 'signup': - return t(`🙌 Complete your sign up to {{siteTitle}}!`, {siteTitle}); + return `🙌 ${t(`Complete your sign up to {{siteTitle}}!`, {siteTitle})}`; case 'signup-paid': - return t(`🙌 Thank you for signing up to {{siteTitle}}!`, {siteTitle}); + return `🙌 ${t(`Thank you for signing up to {{siteTitle}}!`, {siteTitle})}`; case 'updateEmail': - return t(`📫 Confirm your email update for {{siteTitle}}!`, {siteTitle}); + return `📫 ${t(`Confirm your email update for {{siteTitle}}!`, {siteTitle})}`; case 'signin': default: - return t(`🔑 Secure sign in link for {{siteTitle}}`, {siteTitle}); + return `🔑 ${t(`Secure sign in link for {{siteTitle}}`, {siteTitle})}`; } }, getText(url, type, email) { diff --git a/ghost/core/core/server/services/members/emails/signin.js b/ghost/core/core/server/services/members/emails/signin.js index 214090882c9..901b2c58bbf 100644 --- a/ghost/core/core/server/services/members/emails/signin.js +++ b/ghost/core/core/server/services/members/emails/signin.js @@ -4,7 +4,7 @@ module.exports = ({t, siteTitle, email, url, accentColor = '#15212A', siteDomain - ${t('🔑 Secure sign in link for {{siteTitle}}', {siteTitle})} + 🔑 ${t('Secure sign in link for {{siteTitle}}', {siteTitle})}