Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick lang/go mmap patch... #504

Closed
sean- opened this issue May 19, 2017 · 4 comments
Closed

Cherrypick lang/go mmap patch... #504

sean- opened this issue May 19, 2017 · 4 comments

Comments

@sean-
Copy link

sean- commented May 19, 2017

We should cherrypick the mmap(2) patch that officially landed in Go.

We should replace the contents of https://github.com/joyent/pkgsrc/blob/trunk/lang/go/patches/patch-src_runtime_mem__bsd.go with golang/go@13cdd81

CC @jperkin

@mamash
Copy link

mamash commented May 19, 2017

Sean, I made this change per your suggestion earlier:

https://github.com/jsonn/pkgsrc/blob/trunk/lang/go/patches/patch-src_runtime_mem__bsd.go

Is it the same fix and will it work until we hit 1.9? I cherry-picked that change over to 2016Q4.

@sean-
Copy link
Author

sean- commented May 19, 2017

@mamash It's slightly different in that _EAGAIN doesn't exist on the BSDs. The patch that is in place works just fine for Illumos, but I'd rather track what's been officially upstreamed because it's been verified in the official Go test environment.

golang/go@13cdd81#diff-0551b4988cf924970084df57358d1181R62

@mamash
Copy link

mamash commented May 19, 2017

OK cool, I'll align the patch and make note to drop it with 1.9.

@sean-
Copy link
Author

sean- commented May 30, 2017

It looks like this was done in d26605e, thanks @mamash

@sean- sean- closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants