Set up TLS for TestDefaultClientRejectSelfSigned #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous commit we accidentally removed the setup of the TLS test suite which is used to verify the client behavior on self-signed TLS cert. This restores the correct behavior by splitting out a second test suite. previous ref 5642c3e
tgross
force-pushed
the
gh10
branch
2 times, most recently
from
1c4f8c8 to
2d30495
Compare
|
I've added support for Wercker CI to this PR as well. Successful builds look like this: https://app.wercker.com/joyent/gocommon/runs/build/582b7fb1718dd00100502abb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10
As in an issue with gomanta the test suite was not updated with the new router that was added in f676d62. This makes sure we're using the same library in this test suite.
Additionally, in a previous commit (5642c3e) we accidentally removed the setup of the TLS test suite which is used to verify the client behavior on self-signed TLS cert. This restores the correct behavior by splitting out a second test suite.
cc @misterbisson
Test run: