Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

handled prop passed thru as unhandled prop on NotifcationBody #334

Closed
cdaringe opened this issue Nov 21, 2018 · 2 comments · Fixed by #347
Closed

handled prop passed thru as unhandled prop on NotifcationBody #334

cdaringe opened this issue Nov 21, 2018 · 2 comments · Fixed by #347
Assignees

Comments

@cdaringe
Copy link
Contributor

problem

the prop selectedNotification gets passed thru to the element here: https://github.com/Tripwire/octagon/blob/master/src/components/Notification/NotificationBody.jsx#L44

this is invalid, and should be handled. one option could be to wire up https://github.com/layershifter/babel-plugin-transform-react-handled-props. I'm a little iffy on that though. it's a bit of hidden magic and probably isn't super TS friendly. it's not too much effort/cost to just handle these

@andrewleyva
Copy link
Collaborator

it was probably supposed to be passed through explicitly and got missed. thanks for catching that @cdaringe.
hope the new gig is going well and that you're "rolling back the technical debt' #badjoke #sorrynotsorry

@ggascoigne
Copy link
Member

🎉 This issue has been resolved in version 15.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants