Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

feat(layout): trigger build #311

Merged
merged 1 commit into from
Oct 5, 2018
Merged

feat(layout): trigger build #311

merged 1 commit into from
Oct 5, 2018

Conversation

pfaffle
Copy link
Collaborator

@pfaffle pfaffle commented Oct 5, 2018

problem statement

I messed up the semantic release commit format and so a new build wasn't triggered after merging #310.

solution

Add an empty commit to history which does follow the format, so a build happens.

discussion

@pfaffle
Copy link
Collaborator Author

pfaffle commented Oct 5, 2018

Seemed like CircleCI didn't handle the empty commit well, so i tweaked this to make a minor change to the BannerMessage examples file, to remove an unused SUIR Button import.

@pfaffle pfaffle requested a review from andrewleyva October 5, 2018 18:40
@wa11-e
Copy link

wa11-e commented Oct 5, 2018

Woohoo! new surge deployment available for viewing! 🎉 surgereviewmrvbbnamihgetag.surge.sh

Copy link
Collaborator

@andrewleyva andrewleyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@andrewleyva andrewleyva merged commit a0b034e into master Oct 5, 2018
@andrewleyva andrewleyva deleted the add-empty-commit branch October 5, 2018 18:56
@wa11-e
Copy link

wa11-e commented Oct 5, 2018

🎉 This PR is included in version 15.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants