Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow input of faction id by hand when searching #22

Open
wodim opened this issue Jan 19, 2020 · 7 comments
Open

Allow input of faction id by hand when searching #22

wodim opened this issue Jan 19, 2020 · 7 comments

Comments

@wodim
Copy link

wodim commented Jan 19, 2020

When you search for NPCs, there's a list of factions to pick from but it's far from complete.

image

Besides if you go to the page of a faction that's not on that list, like Ambient, and click the Filter these results button:

image

You just get an error:

image

So 1) a filter option, Faction ID, should be added, and 2) (necessarily) factions that are not on that incomplete list should be allowed to be used as filters

Thanks for keeping aowow alive!

@jackpoz
Copy link

jackpoz commented Feb 9, 2020

Factions are defined at https://github.com/TrinityCore/aowow/blob/master/static/js/locale_enus.js#L3561-L3577 . Which factions are missing ?

@wodim
Copy link
Author

wodim commented Feb 9, 2020

I showed an example: Ambient

Another: Prey

@Sarjuuk
Copy link
Collaborator

Sarjuuk commented Feb 23, 2020

it is indeed a predefined list and as such only values on it are accepted by the filter.

unsure if all factions should be in it.

@wodim
Copy link
Author

wodim commented Feb 23, 2020

Any good reason it shouldn't be possible to find things by faction ID?

@Faq
Copy link

Faq commented Aug 15, 2021

unsure if all factions should be in it.

Just wondering why all factions should not be in it? Performance or other reasons?

@wodim
Copy link
Author

wodim commented Aug 15, 2021

This "database viewer" hides a lot of data (like certain npcs, spells...) arbitrarily. I've asked many times and I never got a straight answer.

@jackpoz
Copy link

jackpoz commented Aug 15, 2021

It should show to users only what retail players can see on sites like wowhead and to staff what blizzard employees would see on their internal wowhead-style site.

It doesn't make much sense to show the same to every different role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants