Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to AI v2 #72

Open
goenning opened this issue May 23, 2019 · 8 comments
Open

upgrade to AI v2 #72

goenning opened this issue May 23, 2019 · 8 comments

Comments

@goenning
Copy link

Now that AI v2 is released, can we upgrade this library to use the latest?

I'm happy to provide a PR, because I really need a feature that is in v2.

@MarkPieszak
Copy link
Member

Oh I didn’t know it was officially released out of alpha/beta! Yeah if it isn’t too big of change and you want to give it a shot that’d be amazing!! 🙌🙌

If not I can try to take a crack at it but I’m away next week so might be tough to squeeze it in.

Any help is always super appreciated! ❤️

@goenning
Copy link
Author

I was looking at it now and it seems like v2 is a big rewrite compared to v1

I'll give it a try over the weekend and see how far I can get :)

@MarkPieszak
Copy link
Member

MarkPieszak commented May 28, 2019

You rock! @goenning
Let me know if you need me to look at anything 👍

@goenning
Copy link
Author

Hey Mark, I'm sorry but I didn't get much done last weekend. I'll be off for 2 weeks now, will try again when I'm back. I also couldn't find any reference to v2 on official docs, so I guess it's not that public yet. Feel free to have a look too if you wish.

@ntziolis
Copy link

Is this lib still in active development? Or should we use angular-application-insights-v2 instead?

@michaelmarcuccio
Copy link

@MarkPieszak same question as @ntziolis above, is this enhancement still on hold?

@pkarny
Copy link

pkarny commented Aug 25, 2020

@MarkPieszak We really like your lib it's fine if you are too busy to update ;) Just give the community a hint what should we do ;) should we wait, contribute or just move on? :)

@goenning
Copy link
Author

Just a heads up: I tried updating this package to appinsights v2 long ago, but faced too may breaking changes. Given that we only needed a thin angular compatibility layer, I ended up with this new package: https://github.com/goenning/ng-appinsights

It might not have all features supported by angular-application-insights, but some people might find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants