Health checks seem broken

[qstokkink]

After clicking the health of all the torrents in my search results I get a lot of seemingly dead torrents:

However, after waiting a few seconds and clicking them all again, the torrents come back alive:

[qstokkink]

To my surprise, if I change the following line

tribler/src/tribler/core/torrent_checker/torrent_checker.py

Line 356 in 6a6c8e0

health = aggregate_responses_for_infohash(infohash, cast(List[TrackerResponse], successful_responses))

to

health = aggregate_responses_for_infohash(infohash, cast(List[TrackerResponse], []))

everything starts working (I still have no idea why this could be).

[qstokkink]

I think this logic is wrong. Consider

tribler/src/tribler/core/torrent_checker/torrent_checker.py

Lines 356 to 363 in 6a6c8e0

	health = aggregate_responses_for_infohash(infohash, cast(List[TrackerResponse], successful_responses))
	if health.last_check == 0: # if not zero, was already updated in get_tracker_response
	health.last_check = int(time.time())
	health.self_checked = True
	self.update_torrent_health(health)
	else:
	# We don't need to store this in the db, but we still need to notify the GUI
	self.notify(health)

tribler/src/tribler/core/torrent_checker/torrent_checker.py

Lines 43 to 52 in 6a6c8e0

	def aggregate_responses_for_infohash(infohash: bytes, responses: List[TrackerResponse]) -> HealthInfo:
	"""
	Finds the "best" health info (with the max number of seeders) for a specified infohash.
	"""
	result = HealthInfo(infohash, last_check=0)
	for response in responses:
	for health in response.torrent_health_list:
	if health.infohash == infohash and health > result:
	result = health
	return result

aggregate_responses_for_infohash takes the latest tracker responses and picks the most likely correct health. Then, this fresh valid tracker data is not stored in the database (???), only if there was no tracker data, with 0 seeders and 0 leechers, do we store the result (!?).

I think the check should be as follows:

if health.last_check == 0:
    self.notify(health)  # We don't need to store this in the db, but we still need to notify the GUI
else:
    self.update_torrent_health(health)