Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: BandwidthCommunity may be removed. #7336

Closed
drew2a opened this issue Mar 28, 2023 · 7 comments · Fixed by #7798
Closed

Refactoring: BandwidthCommunity may be removed. #7336

drew2a opened this issue Mar 28, 2023 · 7 comments · Fixed by #7798
Assignees

Comments

@drew2a
Copy link
Contributor

drew2a commented Mar 28, 2023

We still have issues related to the BandwidthCommunity which causes the Tribler crashes.
At the same time, the BandwidthCommunity functionality has not been used for at least a couple of years.

It looks like a big piece of code that could be safely removed.

@synctext
Copy link
Member

can't find the code https://github.com/Tribler/tribler/search?q=BandwidthCommunity&type=code
this is different then the bartercast or ledgerzero community

@sentry-for-tribler
Copy link

Sentry issue: TRIBLER-16Q

@synctext
Copy link
Member

This should be repaired for MeritRank. Please fix the stability issues. For long term lab progress we need a reputation graph.

@sentry-for-tribler
Copy link

Sentry issue: TRIBLER-171

@drew2a
Copy link
Contributor Author

drew2a commented Jan 3, 2024

The error continues to occur in BandwidthCommunity. See the latest: https://sentry.tribler.org/organizations/tribler/issues/2548/.

Should we continue trying to fix them, or should we remove the entire feature as it will eventually be replaced in favor of MeritRank?

@synctext

@synctext
Copy link
Member

synctext commented Jan 3, 2024

Indeed, we might as well delete it all now. This commit from 3 weeks ago deleted a lot.
Then @InvictusRMC and @grimadas can start with a somewhat clean start with MeritRank deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants