You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our usage of dialogs in the GUI code is inconsistent. Specifically, we are creating dialog objects in different widgets classes, which can lead to race conditions and other hidden errors. We suspect that this might be a reason for the (recent) instability of the GUI tests.
I propose to manage all dialogs centrally, i.e., by a single manager. This manager keeps track of the open dialogs and allows us, amongst other features, to close all open dialogs when shutting down. We can also improve the GUI tests by implementing a wait_for_dialog method and remove a few hard-coded timeouts in the process.
The text was updated successfully, but these errors were encountered:
Our usage of dialogs in the GUI code is inconsistent. Specifically, we are creating dialog objects in different widgets classes, which can lead to race conditions and other hidden errors. We suspect that this might be a reason for the (recent) instability of the GUI tests.
I propose to manage all dialogs centrally, i.e., by a single manager. This manager keeps track of the open dialogs and allows us, amongst other features, to close all open dialogs when shutting down. We can also improve the GUI tests by implementing a
wait_for_dialog
method and remove a few hard-coded timeouts in the process.The text was updated successfully, but these errors were encountered: