Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should consider showing torrent health in the 'popular torrents' tab #6444

Closed
devos50 opened this issue Oct 12, 2021 · 7 comments · Fixed by #8052
Closed

We should consider showing torrent health in the 'popular torrents' tab #6444

devos50 opened this issue Oct 12, 2021 · 7 comments · Fixed by #8052

Comments

@devos50
Copy link
Contributor

devos50 commented Oct 12, 2021

See title. When I go to the 'popular torrents' page, I get a list of popular torrents. However, I'm unable to see how popular they are exactly, i.e., is a particular torrent seeded by 10 or 1000 users?

Is there any particular reason why torrent health has been hidden on this page? If not, I would suggest showing this information 👍

@ichorid
Copy link
Contributor

ichorid commented Oct 12, 2021

At first, the health column was there. But there was a problem: when clicking on the health indicator, the results were predominantly 🔴 . The reason is simple: DHT health checks are slow and unreliable over tunnels. So, we disabled the user's ability to click on the health bar. This proved to be rather frustrating, so we removed the health column at all.

I'm out of ideas here.

@devos50
Copy link
Contributor Author

devos50 commented Oct 12, 2021

@ichorid thanks for clarifying!

This proved to be rather frustrating

Was it frustrating for us (as developers) to disable this health check or frustrating from an end-user perspective?

@ichorid
Copy link
Contributor

ichorid commented Oct 12, 2021

Was it frustrating for us (as developers) to disable this health check or frustrating from an end-user perspective?

Frustrating from a user perspective. Disabling it was just a single line of code...

@devos50
Copy link
Contributor Author

devos50 commented Oct 12, 2021

Frustrating from a user perspective.

Did we receive feedback from users that they consider it frustrating (maybe I missed it)? Personally, I wouldn't mind if I was unable to refresh the health on a particular page. Of course, the preferred solution would be to fix the anonymous lookups.

@ichorid
Copy link
Contributor

ichorid commented Oct 12, 2021

Did we receive feedback from users that they consider it frustrating (maybe I missed it)?

If I remember correctly, there was some feedback on the forum. Also, you could try re-enabling it and try it yourself 😉 You won't believe how annoying it is not to be able to check the health of a torrent on click, especially after you got so used to it from Channels UI...

@devos50
Copy link
Contributor Author

devos50 commented Oct 13, 2021

If I remember correctly, there was some feedback on the forum.

Thanks for elaborating! If there was user feedback about this feature, then we can leave it as it currently is and maybe restore this functionality later 👍 . Should this issue be closed then?

@drew2a
Copy link
Contributor

drew2a commented Oct 13, 2021

To me as a user, it is completely fine not to have a health re-check on the popular page (because if torrents are popular, then they are healthy).

@xoriole xoriole modified the milestones: 7.11.0 October, Backlog Oct 20, 2021
@drew2a drew2a self-assigned this Jun 3, 2024
@drew2a drew2a modified the milestones: Backlog, 7.15.0 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants