test_hidden_services broken
#6352
Assignees
Labels
Comments
|
BIG FAT WARNING: 👻 BEWARE 👻 |
|
Gentlemen! 🚬
This is most probably related to arvidn/libtorrent#3542 and thus requires Arvid's attention. The investigation continues. |
|
Great stuff! Hopefully we get a reproducible bug trigger script or pull request upstream to Arvid. |
|
Managed to capture the uTP log (had to modify Libtorrent source a bit 😉 ). The log does not look normal at all: uTP logThe log is for two Libtorrent sessions exchanging uTP data locally through Tribler SOCKS5 connections on both sides. This is 100% reproducible, although it will be hard to reproduce outside of Tribler (e.g. via some random SOCKS server), because of all the dynamic port assignments, etc. Also, there seem to be almost to SOCKS5 servers that support UDP association. The interesting part of the log is: Seems like the seeder acknowledges the connection and then immediately destroys the uTP stream object for some mysterious reason 💥 (p.s. the "normal" exchange in the "passing" anonymous download test features some packet loss, which is maybe(?) expected for a local transfer?) |
|
[Cross-ref] Fix mentioned here: #6481 (comment) |
|
@ichorid since you're assigned, could you take care of clicking "Create pull request" on main...egbertbouman:fix_hs_test ? Then we can finally close this issue. |
|
BTW I can do this if @ichorid does not have time. |
@egbertbouman 's patch does not fix the test for me on Libtorrent 1.2.14. I'm currently testing Arvid's patch. Unfortunately, that one is for Libtorrent 2.0, which complicates things further. |
|
@ichorid As explained in #6481 (comment), you need both the patch and libtorrent <1.2.13. I'm not sure which version the testers are running, but if they're using <1.2.13 the patch would allow you to re-enable the hidden seeding test. |
Exactly! Just wanted to add this comment. So, we have two options here:
In the current circumstances, I'd say the safer option is the downgrade (because God knows how long will it take to backport the patch, and then maintain it for all developers...) |
|
@xoriole , how hard would it be to downgrade our builders and testers to 1.2.12? |
Only Linux builder has libtorrent 1.2.13 and the rest use < 1.2.10, so it is only one builder, which should be quick. |
|
I've tested @egbertbouman 's and Arvid's solutions. Here is the result:
Conclusion: the Egbert's fix is a prerequisite for the test to work at all. Thanks, @egbertbouman , you saved us again 👍 🎉 👏 So, the best strategy is to first update/downgrade all of our machines to 1.2.12, then apply Egbert's fix, and skip 1.2.14 altogether. |
|
@egbertbouman , would you care to open a PR for your fix, or should I apply it myself? |
|
@ichorid Sure, I'll open the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tribler/src/tribler-core/tribler_core/modules/tunnel/test_full_session/test_tunnel_community.py
Lines 250 to 254 in 3343308
This test is key in delivering #3. It should be fixed and "unskipped".
The text was updated successfully, but these errors were encountered: