Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move code from the tribler_core module to tribler_common module where appropriate #5645

Closed
devos50 opened this issue Oct 15, 2020 · 1 comment · Fixed by #6755
Closed

Move code from the tribler_core module to tribler_common module where appropriate #5645

devos50 opened this issue Oct 15, 2020 · 1 comment · Fixed by #6755
Labels
type: enhancement

Comments

@devos50
Copy link
Contributor

devos50 commented Oct 15, 2020

Currently, we have many occurrences in the code where the GUI is importing modules in the tribler_core module directly. This imported code usually consists of identifiers and utility functions (e.g., JSON encode/decode). Code that is used by both the GUI and the core, should go to the tribler_common module instead.
@drew2a drew2a modified the milestones: Next-next release, Backlog Sep 15, 2021
@drew2a drew2a mentioned this issue Feb 4, 2022
Merged
@drew2a
Copy link
Contributor

drew2a commented Feb 4, 2022

The tribler_core occurrences in the GUI package:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove common package drew2a/tribler
2 participants
@devos50 @drew2a