Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger hard to use #5340

Closed
ichorid opened this issue May 28, 2020 · 6 comments
Closed

Logger hard to use #5340

ichorid opened this issue May 28, 2020 · 6 comments

Comments

@ichorid
Copy link
Contributor

ichorid commented May 28, 2020

Our logger now is hard to use. It should be configured much easier, reconfigurable by the user, break in case of big modules refactorings.

@devos50
Copy link
Contributor

devos50 commented Sep 24, 2020

Is this issue addressed sufficiently now that we moved to pyyaml-based configurations?

@ichorid
Copy link
Contributor Author

ichorid commented Sep 24, 2020

No, it is still not. The user still can't configure the thing on their own, because Tribler looks for yaml-based log config only in the source dirs. The user-configurable yaml - based logger config must be applied after the default one, and it should only contain changed entries. Otherwise, it is too wordy.

@devos50
Copy link
Contributor

devos50 commented Sep 24, 2020

Ah I see. I actually wonder if users would use this feature. The log is not something that users are going to investigate. Instead, they just send their stack traces to us, and we debug by inspecting the logs, adding more logging statements if necessary.

At best, this would be a nice feature for developers but I think they can as easily just modify the main logger.yaml file.

@ichorid
Copy link
Contributor Author

ichorid commented Sep 24, 2020

This is a really important feature for developers, as it allows us to enable logging in compiled Tribler packages.

@xoriole
Copy link
Contributor

xoriole commented Oct 30, 2020

Actually, logging is not working at all. I don't see any logs being written to the log file.
Also the reason why logs section in the debug pane.
Screen Shot 2020-10-30 at 10 15 52

@qstokkink
Copy link
Contributor

The logger has been reworked in the latest Tribler code and this issue is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants