Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reading bootstrap SQL dump at each startup #4862

Closed
ichorid opened this issue Sep 26, 2019 · 7 comments
Closed

Stop reading bootstrap SQL dump at each startup #4862

ichorid opened this issue Sep 26, 2019 · 7 comments

Comments

@ichorid
Copy link
Contributor

ichorid commented Sep 26, 2019

Currently, we fully read and execute the bootstrap SQL dump at each startup. This increases the startup time (which is critical for a torrent client). Also, it puts unnecessary load on TrustChain SQL engine, which can potentially slow down other TrustChain-related startup sequences.

Instead, we should detect if the current bootstrap file has already been processed before, and only load the SQL dump if necessary.

@qstokkink
Copy link
Contributor

We could turn this into a REST endpoint and have the GUI control when to perform the bootstrap SQL statement.

@devos50
Copy link
Contributor

devos50 commented Apr 1, 2020

I suppose we will address this issue after the 7.5 release?

@ichorid
Copy link
Contributor Author

ichorid commented Apr 1, 2020

For 7.5, we just disabled reading SQL from the bootstrap file. We can solve it later in 7.5.x or 7.6 series.

@ichorid
Copy link
Contributor Author

ichorid commented Oct 20, 2020

By, Trustchain!

@ichorid ichorid closed this as completed Oct 20, 2020
@devos50 devos50 reopened this Oct 20, 2020
@devos50
Copy link
Contributor

devos50 commented Oct 20, 2020

TrustChain is not entirely gone yet and the bootstrap code is still there. We left it in since it will trigger bandwidth payouts which will make sure that you are connected to other users.

The content in the bootstrap file, however, is currently not being parsed. There are plans to address this soonish.

@ichorid
Copy link
Contributor Author

ichorid commented Oct 20, 2020

🤷

@qstokkink
Copy link
Contributor

This code seems to have been removed now making this issue no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants