Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GigaChannel community DB access batching #4249

Closed
ichorid opened this issue Feb 25, 2019 · 4 comments
Closed

GigaChannel community DB access batching #4249

ichorid opened this issue Feb 25, 2019 · 4 comments
Assignees

Comments

@ichorid
Copy link
Contributor

ichorid commented Feb 25, 2019

Currently, for each incoming GigaChannel community gossip packet we open a separate DB session and process packets individually. This will really start to stress the DB when the gossip stream will rise to dozens of packets per second. We should solve this problem somehow, for example by batching DB access.

@synctext
Copy link
Member

Note, IO Batching slowed us down in the past.

@ichorid
Copy link
Contributor Author

ichorid commented Feb 25, 2019

That's why we're gonna "science this out" by setting up some meaningful experiments.

@synctext
Copy link
Member

synctext commented Dec 3, 2020

@kozlovsky Are we still closing and opening DB sessions for each incoming UDP packet?
Are we expecting any gains from refactoring this?

@drew2a drew2a modified the milestones: Next-next release, Backlog Sep 15, 2021
@ichorid ichorid removed their assignment Sep 28, 2021
@drew2a
Copy link
Contributor

drew2a commented Jun 3, 2024

It is not relevant anymore:

@drew2a drew2a closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants