Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the token balance graph show total balance instead of one for upload/download #4164

Closed
Thomasedv opened this issue Jan 22, 2019 · 2 comments

Comments

@Thomasedv
Copy link

Thomasedv commented Jan 22, 2019

Tribler version/branch+revision:

Tribler 7.1.2

I've been using Tribler for some time, and find that i very easily go in the negatives, likely as a result of torrents that are highly available, but not in demand, at least on Tribler net. (Upload almost exclusively remain at 0 for these torrents) As a result, the upload and download lines will split significantly, and make it practically useless to try to monitor recent changes in upload.
By moving over to a total balance in the graph, that gradual changes would be much more apparent, at least when do actively downloading.
The drawback would be, that though, you can't realistically observe upload when downloading with the proposed method, but in it's current state, it's not all that much better.

An alternative, if possible, is to do the total way, and color a vertical line under the balancegraph as "download" for the given interval, and another for upload, if that is a feasible option. See quick mockup:

image

Imagine the top shaded area could be colored blue for given, and another shaded area under showing the taken amount. (Samle code for graph can be shared)

As minor point, not worth an issue, moving to smaller circle orbs instead of large ones for each "record" in the graph, would also likely increase readability, as the large points overshadow the finer changes of the lines in the current implementation. Or as in the above image, not use points at all, depeding on what you prefer.

@xoriole xoriole added this to the V7.3: Python 3 milestone Jan 23, 2019
@xoriole
Copy link
Contributor

xoriole commented Jan 23, 2019

@Thomasedv Thank you for the suggestion and I appreciate your effort in creating the graph mockup. I agree that monitoring the changes in the recent uploads when there is a big (negative) difference in the balance is not so useful and showing the differential value could be more informative. However, the differential upload value will still remain small and be less visible when plotted on the same graph with the same scale. We'll discuss it in the team and update the issue.

@drew2a
Copy link
Contributor

drew2a commented Jun 6, 2024

It is not relevant anymore:

@drew2a drew2a closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants