Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Tracker to Torrent #2529

Closed
0x27 opened this issue Aug 26, 2016 · 6 comments · Fixed by #8167
Closed

Feature Request: Add Tracker to Torrent #2529

0x27 opened this issue Aug 26, 2016 · 6 comments · Fixed by #8167

Comments

@0x27
Copy link

0x27 commented Aug 26, 2016

A good feature to have would be the ability to add a tracker to a torrent that appears to be badly seeded (or relying on some dead trackers). For whatever reason, this usually works out pretty well for me in other clients to "revive" torrents that initially seem to be dead.

@whirm whirm added this to the Backlog milestone Aug 29, 2016
@gitbugged
Copy link

Definitely interested in this feature as well. Over 90% of the trackers included are dead, which make it much more difficult for Tribler to get started.

I wrote python hack to wipe all trackers from the entire DB and inject my own, it's not overly pretty but it works, and maybe someone else can find it useful.

injecttrackers.py

@qstokkink qstokkink removed this from the Backlog milestone Aug 23, 2024
@qstokkink
Copy link
Contributor

We have facilities to add trackers to downloads:

def add_trackers(self, trackers: list[str]) -> None:
"""
Add the given trackers to the handle.
"""

We could implement this feature by simply exposing this method to the GUI.

@qstokkink qstokkink self-assigned this Aug 30, 2024
@qstokkink
Copy link
Contributor

qstokkink commented Sep 2, 2024

I tried the approach that I mentioned above and this seems to work just fine. Now, I need an GUI design. I'm thinking of adding a column to the trackers table of a download's details:

Add/RemoveTrackerStatusPriority
[DHT]Working
[PeX]Working
( Remove button )Tracker 1Working
( Remove button )Tracker 2Not contacted yet
( Add button ) [ INPUT FIELD ]

@qstokkink
Copy link
Contributor

qstokkink commented Sep 2, 2024

When solving this, we should probably also include #1797 and allow the GUI to move trackers "up and down" to increase/decrease their priority. I updated my previous post with a "priority".

@qstokkink qstokkink added this to the 8.1.0 milestone Sep 2, 2024
@qstokkink
Copy link
Contributor

qstokkink commented Sep 4, 2024

My initial prototype is here: https://github.com/qstokkink/tribler/tree/add_tracker_add

I think I'll drop the initial prototype though. After sleeping on this, I think it might be better to simply have a right-click context menu that allows you to change tracker priority, remove trackers, and add a tracker.

@qstokkink
Copy link
Contributor

qstokkink commented Sep 19, 2024

We can use react-sortable-hoc to re-order trackers to change their priority.

Demo: http://clauderic.github.io/react-sortable-hoc/#/basic-configuration/drag-handle?_k=29udje
Source: https://github.com/clauderic/react-sortable-hoc/blob/master/examples/drag-handle.js

This avoids a right-click context menu, which is not really "web-like".

Looking into how libtorrent handles trackers, order doesn't really exist - only tiers. Perhaps it's better to simply have a "Check Tracker Now" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants