-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The video server should be rewritten so it's using Twisted #2391
Comments
@synctext So until this complete rewrite is done, we don't have a video server that will work on Android. |
ai, bummer. @brussee One I could find quickly: Seek is more complex then linear download. better then download full and play. But first document existing code... |
tsap codebase with rpc calls for streaming: btw refreshing to see all this old code.. |
@brussee I'm pretty sure that the video player works with the Twistd plugin (recently checked). I was probably confused about the 'VideoPlayer' class being dependent on the GUI but iirc, it works without. Can you try it? Just use curl or wget to test it. |
Probably fixed in #5301 |
Our current video server is dependent on
VideoPlayer
which in turn is dependent on the wx GUI. Moreover, the video server contains a lot of blocking code (time.sleep
andthreading.event
occurrences), making the reactor and Tribler block when the user watches a video.This video server should be rewritten in Twisted, making use of a static
File
object. The following should happen when a request to this video server is made:File
object immediately. If they are not available, set the download priority of these bytes to the maximum and return a deferred that fires when these bytes are available.The text was updated successfully, but these errors were encountered: