Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe Tribler v6.5.0 should be called v7.0.0? #1703

Closed
vi opened this issue Oct 29, 2015 · 9 comments
Closed

Maybe Tribler v6.5.0 should be called v7.0.0? #1703

vi opened this issue Oct 29, 2015 · 9 comments
Milestone

Comments

@vi
Copy link
Contributor

vi commented Oct 29, 2015

Storage of collected torrents files got changed in a major way, requiring migration.

User is probably not expected to start Tribler <= 6.4.3 after starting the new Tribler...

That looks more like a Tribler v7.

@whirm
Copy link

whirm commented Oct 30, 2015

@synctext maybe you want to join the discussion?

We usually consider the third digit (bugfix releases) to keep on disk backwards compatibility, 2nd is new features (often requiring on disk data changes like the new torrent and thumbnail storage system), and third is major breakage such as protocol-level incompatibilities.

What we maybe could do is to have a dialog warning people about on disk compatibility changes before going forth.

Maybe a .zip backup could be done too.

@whirm whirm added this to the V6.5.x milestone Oct 30, 2015
@whirm whirm modified the milestones: V6.5.x, V6.6 WX3 Feb 17, 2016
@lfdversluis
Copy link

Just my cents here, I guess launching all the items planned for 6.7 (credits, ratio enforcement, code/speed improvements, (major) gui update, multichain etc.) can be called v7. 6.6 contains the upgrade to wx3 with additional bug fixes; some items but nothing major (I think).

@vi
Copy link
Contributor Author

vi commented Feb 19, 2016

The main issue that there is migration procedure from 6.4 to 6.5 (delecting collected_torrent_files, etc.) and user is not supposed to downgrade back to 6.4. That may be called "breaking change" requiring major version bump.

@devos50
Copy link
Contributor

devos50 commented Mar 18, 2016

Since 6.5 is already released, we cannot make it backwards compatible with 6.4.3 unfortunately. We should keep this in mind for next releases.

@whirm
Copy link

whirm commented Mar 18, 2016

What we should do, is to offer to make a backup of the data before the migration or keep a different state directory for each new Tribler on disk format change like other programs do, (Android Studio comes to mind).

@lfdversluis
Copy link

@whirm This issue can be closed, it is no longer relevant. Re the backup of the data, if it's desirable it should go into a new issue (wasn't there one?). Apparently backwards compatibility may be broken more in the future, as per @synctext mention in #2106.

@whirm
Copy link

whirm commented May 17, 2016

@lfdversluis that's a differend kind of break, one thing is breaking on disk format compatibility and the other is protocol compatibility.

@synctext
Copy link
Member

synctext commented May 17, 2016

The naming convention is actually never documented or formalized. It's user-uptake focused.
The convention I used so far was something like: new major number when release has an understandable killer feature that can be explained in a TorrentFreak/Arstechnica post.

Putting this aside, next release has a lot of radical changes (QT GUI, credits, Android, etc.).
So 7.0 probably.

@synctext
Copy link
Member

Current plan... Next version with GUI re-write will be 7.0
When anonymous download goes out of Beta: 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants