Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite growing dictionary in Dispersy statistics #568

Open
devos50 opened this issue May 31, 2018 · 2 comments
Open

Infinite growing dictionary in Dispersy statistics #568

devos50 opened this issue May 31, 2018 · 2 comments
Labels

Comments

@devos50
Copy link
Contributor

devos50 commented May 31, 2018

The dictionaries stored in the Dispersy statistics (MessageStatistics) are always growing and never pruned. When running Tribler for extended periods of time, this leads to significant memory usage. See for instance https://github.com/Tribler/dispersy/blob/devel/statistics.py#L82. It seems that we're storing full details about all introduction requests sent and received. The same goes for walk_failure_dict.

To fix this, we can either periodically prune the dictionaries or disable the Dispersy statistics. @qstokkink do you have any comments on this? I think it's important enough to fix this for Tribler 7.1 👍

@devos50 devos50 added the bug label May 31, 2018
@qstokkink
Copy link
Contributor

Dispersy is end of life, therefore I will close this issue. so we can simply remove/disable these statistics imo.

@devos50
Copy link
Contributor Author

devos50 commented May 31, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants