We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodeOps.createElement
props === null
As of PR (80f8a2e), some playgrounds are broken. And user code is likely also broken.
Broken playground example:
http://localhost:5173/events/dynamic-objects
Uncaught (in promise) TypeError: props is null createElement nodeOps.ts:34
Here's the problem line in src/nodeOps.ts:
src/nodeOps.ts
function createElement(tag: string, _isSVG: undefined, _anchor: any, props: Partial<WithMathProps<TresObject>> = {}): TresObject | null {
The signature was changed from the signature in the Vue docs:
createElement( type: string, isSVG?: boolean, isCustomizedBuiltIn?: string, vnodeProps?: (VNodeProps & { [key: string]: any }) | null ): HostElement
The new signature isn't equivalent. The docs' version says Vue can pass null for props.
null
props
But if nodeOps.createElement gets an explicit null, it throws on the next line when checking if (!props.args).
if (!props.args)
Revert the signature and readd the check for null props.
N/A - see above
main
pnpm dev
N/A
npm
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Problem
As of PR (80f8a2e), some playgrounds are broken. And user code is likely also broken.
Broken playground example:
http://localhost:5173/events/dynamic-objects
Error:
Here's the problem line in
src/nodeOps.ts
:The signature was changed from the signature in the Vue docs:
The new signature isn't equivalent. The docs' version says Vue can pass
null
forprops
.But if
nodeOps.createElement
gets an explicitnull
, it throws on the next line when checkingif (!props.args)
.Solution
Revert the signature and readd the check for null
props
.Reproduction
N/A - see above
Steps to reproduce
main
Tres branch.pnpm dev
System Info
Used Package Manager
npm
Code of Conduct
The text was updated successfully, but these errors were encountered: