Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate file name before downloading #84

Closed
Trenly opened this issue Oct 7, 2021 · 2 comments · Fixed by #85
Closed

Validate file name before downloading #84

Trenly opened this issue Oct 7, 2021 · 2 comments · Fixed by #85
Assignees
@Trenly
Labels
Bug Something isn't working
Milestone
2.0 -> Master

Comments

@Trenly
Copy link
Owner

Trenly commented Oct 7, 2021

Some URLs result in an invalid file name. These should be caught and handled before attempting to download the file
@Trenly Trenly added the Bug Something isn't working label Oct 7, 2021
@Trenly Trenly added this to the 2.0 -> Master milestone Oct 7, 2021
@Trenly Trenly self-assigned this Oct 7, 2021
@vedantmgoyal9
Copy link

vedantmgoyal9 commented Oct 8, 2021 •
edited
Loading

@Trenly I think you can open #83 so that people who are testing v2.0 could inform about the bugs.

@Trenly
Copy link
Owner Author

Trenly commented Oct 8, 2021

@Trenly I think you open #83 so that people who testing v2.0 could inform about the bugs.

No. I opened #83 to inform others. New issues should still be filed for bugs, as they still should be tracked independently

@Trenly Trenly mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Trenly Trenly

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.0 -> Master
Development

Successfully merging a pull request may close this issue.

Ensure file names are valid before saving Trenly/winget-pkgs
2 participants
@Trenly @vedantmgoyal9