Problems in parsing the manifest when there is no en-US locale

[vedantmgoyal9]

From logs of workflow run vedantmgoyal9/vedantmgoyal9#98 on my repo:

Actual behaviour:
https://github.com/microsoft/winget-pkgs/pull/29305/files

I think the problem occurs because the is only one locale: ko-KR.

Question:
Is it compulsory that en-US should be there with a package?

[vedantmgoyal9]

Existing manifests: https://github.com/microsoft/winget-pkgs/tree/master/manifests/r/Riiid/pollapo/0.0.14

[jedieaston]

That's not the problem, the problem is that Riiid.pollapo.locale.ko-KR.yaml has the type defaultLocale when it should have the type locale. You can't have two defaults.

[vedantmgoyal9]

I could not understand what are you trying to say. The repo has only one defaultLocale i.e. ko-KR

[jedieaston]

But your PR has two files in it that both claim they are ManifestType: defaultLocale.

[jedieaston]

It seems like YamlCreate.ps1 makes assumptions that the defaultLocale will always be en-US (see 1615 among other places). I wonder if one of those is the problem here.

[Trenly]

It seems like YamlCreate.ps1 makes assumptions that the defaultLocale will always be en-US (see 1615 among other places). I wonder if one of those is the problem here.

I believe that is the issue; I did look at the version 1.0 script, and it seems the issue may exist there as well, but I haven't tried it.

I'm not sure the best way to fix this. Maybe looking at the last set of manifests, finding the file that has the default locale, and setting it to that?

[jedieaston]

Maybe looking at the last set of manifests, finding the file that has the default locale, and setting it to that?

That's what I usually do. In fact, winget didn't even list en-US as the default until June.

This presents a little bit of a problem if the user of YamlCreate.ps1 doesn't know the language listed as default, but I guess they just wouldn't touch any of the fields in defaultLocale?

[Trenly]

This presents a little bit of a problem if the user of YamlCreate.ps1 doesn't know the language listed as default, but I guess they just wouldn't touch any of the fields in defaultLocale?

I think that's a reasonable thing to assume