Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in automatic detection of PackageFamilyName #45

Closed
vedantmgoyal9 opened this issue Sep 22, 2021 · 4 comments · Fixed by #55
Closed

Improvement in automatic detection of PackageFamilyName #45

vedantmgoyal9 opened this issue Sep 22, 2021 · 4 comments · Fixed by #55
Labels
Bug Something isn't working

Comments

@vedantmgoyal9
Copy link

Description of the new feature/enhancement

When a user selects manual entering of Installer Hash:
image
then the option for finding PackageFamilyName should download the URL instead of throwing an error:
image

Proposed technical implementation details (optional)

if ($null -eq $script:dest)
  download the installer
else
  continue with installation of package and find PackageFamilyName

@vedantmgoyal9 vedantmgoyal9 changed the title Do not prompt for automatic detection of PackageFamilyName when the user does not download the URL Improvement in automatic detection of PackageFamilyName Sep 22, 2021
@Trenly Trenly added the Bug Something isn't working label Sep 22, 2021
@Trenly
Copy link
Owner

Trenly commented Sep 22, 2021

@vedantmgoyal2009 can you provide the Package Identifier that you encountered this issue with?

@vedantmgoyal9
Copy link
Author

vedantmgoyal9 commented Sep 23, 2021

There isn't any package identifier. When there is any MSIX/APPX installer, and we manually enter the hash (we do not download the installer), we get this error when we select "automatically find PackageFamilyName" because the file does not exist locally.

@Trenly
Copy link
Owner

Trenly commented Sep 23, 2021

There isn't any package identifier. When there is any MSIX/APPX installer, and we manually enter the hash (we do not download the installer), we get this error when we select "automatically find PackageFamilyName" because the file does not exist locally.

Yes, I know that; Is there a package which exists that I can use when testing the fix? In order to test, I need a package which has an APPX or MSIX installer

@vedantmgoyal9
Copy link
Author

PackageIdentifier: Automattic.Simplenote
https://github.com/Automattic/simplenote-electron/releases/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants