Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing merge conflicts #536

Closed
ensata opened this issue Jul 22, 2015 · 2 comments
Closed

Preventing merge conflicts #536

ensata opened this issue Jul 22, 2015 · 2 comments

Comments

@ensata
Copy link
Contributor

ensata commented Jul 22, 2015

I am way too tired for this. Here are some rules to follow in your editing to prevent merge conflicts, and make it easier to follow.

  1. Edit lines in groups. For example, edit a chunk of 100 lines, from 1-100, or 101-200, etc.
  2. Write down the chunk you reviewed in the commit summary.
  3. Do not edit more than 300 lines in a file in a single commit/pull request. GitHub will not generate a diff and you will need to use the command line or dig into the commit history to track problems.

I am adding this to my style guide, which I doubt anyone will read. Please add at least point 3 to the Wiki, and start telling people to read the damn thing.

@imcgames
Copy link
Contributor

Yup, agreed.
If you have more suggestions, share it with us here: #540

@vtange
Copy link
Contributor

vtange commented Jul 23, 2015

if you guys need an example, I've been doing it like:
[FILENAME] ### - ### rev# + details + any broad changes like the doppelsoldner fix

@ensata ensata closed this as completed Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants