This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Add header to SlidingPanel component #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asci
reviewed
Aug 8, 2017
| @@ -1,4 +1,6 @@ | |||
| import React, { Component, PropTypes } from 'react'; | |||
| import React, { Component } from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
asci
reviewed
Aug 8, 2017
|
|
||
| const SlidingPanelHeader = ({ title }) => { | ||
| if (!title) { | ||
| return <noscript />; |
There was a problem hiding this comment.
It was null in my first implementation. But then I stuck with testing, it causes this error. Seems like unless we migrated to React 15 we still need to use noscript. By the way, I've searched other components and found many places where we also use noscript. Once we migrated I think could be nice to get rid of them.
There was a problem hiding this comment.
@asci it is only available on React 15:
There was a problem hiding this comment.
I forget every time:D When we'll migrate?
asci
reviewed
Aug 8, 2017
| @@ -8,19 +8,20 @@ describe('SlidingPanel', () => { | |||
| describe('#render()', () => { | |||
| it('render with default props and mods provided', () => { | |||
| const renderTree = mount( | |||
| <SlidingPanel mods={['test']}>Test</SlidingPanel> | |||
| <SlidingPanel mods={['test']} title="Test Title">Test</SlidingPanel> | |||
There was a problem hiding this comment.
this is not default props, please add new test
There was a problem hiding this comment.
Ah, okay. Got it. Will do now
froskie
approved these changes
Aug 8, 2017
iwwwi
approved these changes
Aug 8, 2017
asci
approved these changes
Aug 8, 2017
mAiNiNfEcTiOn
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT DOES THIS PR DO:
slidingPanelHeadercomponent (for now internally, insideslidingPanel).titletoslidingPanelcomponent. If it's defined we do show header.slidingPanelcomponent is changed to support multiple close buttons.SCREENSHOT:
WHERE SHOULD THE REVIEWER START:
UNIT TESTS: