You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Supporting importing the components individually from top-level imports:
importButtonfrom'travix-ui-kit/Button';
I would be happy to see named exports for individual components too (this will help in migration keeping backwards compatibility as mention at the bottom):
import{Button}from'travix-ui-kit/Button';
Why?
If we go ahead with Adaptive Design (see #322) AND use UI-Kit in a server, we don't want to load ALL the components in memory.
Some other not-so-high-prio benefits would include statically analyzing our source code everywhere to figure out unused components that we ship from UI-Kit.
Backwards compatibility
We can still keep backwards compatibility. Just map travix-ui-kit/* to travix-ui-kit as Webpack's externals, and we are good to go.
The text was updated successfully, but these errors were encountered:
Currently
We import components like this:
Proposal
Supporting importing the components individually from top-level imports:
I would be happy to see named exports for individual components too (this will help in migration keeping backwards compatibility as mention at the bottom):
Why?
If we go ahead with Adaptive Design (see #322) AND use UI-Kit in a server, we don't want to load ALL the components in memory.
Some other not-so-high-prio benefits would include statically analyzing our source code everywhere to figure out unused components that we ship from UI-Kit.
Backwards compatibility
We can still keep backwards compatibility. Just map
travix-ui-kit/*
totravix-ui-kit
as Webpack'sexternals
, and we are good to go.The text was updated successfully, but these errors were encountered: